Skip to content

Comments

chore: e2e for validation ui#1840

Open
maxy-shpfy wants to merge 1 commit into02-20-chore_e2e_test_for_sticky_notesfrom
02-21-chore_e2e_for_validation_ui
Open

chore: e2e for validation ui#1840
maxy-shpfy wants to merge 1 commit into02-20-chore_e2e_test_for_sticky_notesfrom
02-21-chore_e2e_for_validation_ui

Conversation

@maxy-shpfy
Copy link
Collaborator

@maxy-shpfy maxy-shpfy commented Feb 21, 2026

Description

Added comprehensive test identifiers (data-testid attributes) to validation UI components and created end-to-end tests for pipeline validation functionality. The test identifiers enable reliable testing of validation groups, individual validation issues, input value fields, and info boxes. The new e2e test suite covers the complete validation workflow including error detection, issue expansion, navigation to problematic nodes, connecting components, creating input nodes, and resolving validation issues.

Type of Change

  • New feature
  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots

Screen Recording 2026-02-22 at 9.31.57 PM.mov (uploaded via Graphite)

Test Instructions

  1. Run the new e2e test suite: npm run test:e2e -- validation-ui.spec.ts
  2. Verify that all validation UI interactions work as expected:
    • Create a new pipeline and add components
    • Check that validation errors appear for components with missing required inputs
    • Expand validation groups to see individual issues
    • Click on validation issues to navigate to the problematic nodes
    • Connect components and verify error count decreases
    • Create input nodes via CMD+drag and set values to resolve all issues
  3. Ensure existing validation functionality remains unchanged

Additional Comments

The test identifiers are designed to be specific and descriptive, including variant information for info boxes and issue levels for validation items. The e2e tests use a serial execution mode to maintain state between test steps, simulating a realistic user workflow through the validation process.

Copy link
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maxy-shpfy maxy-shpfy marked this pull request as ready for review February 22, 2026 02:58
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner February 22, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant