chore: e2e for secrets in argument editor#1838
Open
maxy-shpfy wants to merge 1 commit into02-19-chore_e2e_for_secrets_management_uifrom
Open
chore: e2e for secrets in argument editor#1838maxy-shpfy wants to merge 1 commit into02-19-chore_e2e_for_secrets_management_uifrom
maxy-shpfy wants to merge 1 commit into02-19-chore_e2e_for_secrets_management_uifrom
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
This was referenced Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added comprehensive end-to-end tests for the secrets in component arguments feature. The test suite verifies the complete workflow from enabling the secrets beta flag, creating secrets, dropping components onto the canvas, assigning secrets to arguments, and preparing pipeline runs.
Enhanced test coverage by adding
data-testidattributes to key UI components including the "Use Secret" button, argument input fields, and secret argument inputs to enable reliable test automation.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
npm run test:e2e -- secrets-in-arguments.spec.tsAdditional Comments
The test includes a custom Github component fixture that simulates a real-world use case requiring a secret (GitHub Personal Access Token). The test suite uses serial mode to ensure proper state management across test steps and includes proper cleanup to avoid test pollution.