Skip to content

Comments

fix: e2e tests failures#1828

Merged
maxy-shpfy merged 1 commit intomasterfrom
02-19-fix_e2e_tests_failures
Feb 20, 2026
Merged

fix: e2e tests failures#1828
maxy-shpfy merged 1 commit intomasterfrom
02-19-fix_e2e_tests_failures

Conversation

@maxy-shpfy
Copy link
Collaborator

@maxy-shpfy maxy-shpfy commented Feb 20, 2026

Fix e2e test flakiness and improve component interaction handling

Changes

  • Set explicit timeouts for Playwright tests: 10 seconds for CI environment and 60 seconds for local development with 10 second assertion timeout
  • Enhanced debounce utility with cancel() method to prevent race conditions
  • Improved ComponentHoverPopover to properly cancel pending hover actions when clicking or closing
  • Added test IDs to ComponentDetailsDialog and import component button for more reliable element selection
  • Updated test helpers to wait for React Flow canvas with extended timeout for Suspense loading states
  • Removed flaky "initial set of folders" tests that were environment-dependent
  • Improved dialog interactions by using keyboard shortcuts instead of potentially out-of-view close buttons
  • Enhanced component details dialog selectors to be more specific and reliable

Copy link
Collaborator Author

maxy-shpfy commented Feb 20, 2026

@maxy-shpfy maxy-shpfy force-pushed the 02-19-fix_e2e_tests_failures branch 8 times, most recently from 3467948 to a2a5aac Compare February 20, 2026 06:38
@maxy-shpfy maxy-shpfy marked this pull request as ready for review February 20, 2026 06:45
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner February 20, 2026 06:45
await page.close();
});

test("initial set of folders", async () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoiding duplicated tests

@maxy-shpfy maxy-shpfy force-pushed the 02-19-fix_e2e_tests_failures branch from a2a5aac to 8765a42 Compare February 20, 2026 06:53
Copy link
Collaborator Author

maxy-shpfy commented Feb 20, 2026

Merge activity

  • Feb 20, 4:09 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 20, 4:09 PM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy merged commit 4118005 into master Feb 20, 2026
8 checks passed
@maxy-shpfy maxy-shpfy deleted the 02-19-fix_e2e_tests_failures branch February 20, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants