Open
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
maxy-shpfy
changed the base branch from
02-19-fix_e2e_tests_failures
to
graphite-base/1830
maxy-shpfy
force-pushed
the
02-19-chore_e2e_for_secrets_management_ui
branch
from
d15fb13 to
2d853a5
Compare
maxy-shpfy
force-pushed
the
graphite-base/1830
branch
from
8765a42 to
4118005
Compare
maxy-shpfy
force-pushed
the
02-19-chore_e2e_for_secrets_management_ui
branch
2 times, most recently
from
12e92e9 to
3df6bd9
Compare
maxy-shpfy
force-pushed
the
02-19-chore_e2e_for_secrets_management_ui
branch
from
3df6bd9 to
59e1f5d
Compare
This was referenced Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added comprehensive test identifiers (
data-testidattributes) to all secrets management components and implemented a complete end-to-end test suite. The test identifiers enable reliable automated testing of the secrets management functionality, covering all user interactions including creating, editing, removing secrets, and handling empty states.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Secrets UI e2e.mov (uploaded via Graphite)
Test Instructions
npm run test:e2e -- secrets-management.spec.tsAdditional Comments
The e2e tests run in serial mode due to shared secrets state and are designed to be idempotent with proper cleanup. Each test creates and removes its own test data to avoid interference between test runs.
This test spec fully interacts with a backend.