test: use specific snapshot matchers to avoid platform discrepancies#206
test: use specific snapshot matchers to avoid platform discrepancies#206
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
=========================================
Coverage 70.59% 70.59%
Complexity 995 995
=========================================
Files 49 49
Lines 3183 3183
=========================================
Hits 2247 2247
Misses 936 936 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f5f8c07 to
54e99de
Compare
54e99de to
799cefa
Compare
add dev spatie/pixelmatch-php
|
It seems that you forgot to delete these two files (in the
(Thus, Git considered the two identical files in Edit: submitted #212 about this. |
|
I was afraid that the addition of Node.js would make the jobs' setup significantly slower (adding a few dozens of seconds), but actually it just adds a handful of seconds, which is great (and impressive). So it's not problematic in practice. Furthermore, it only affects testing and not production. However, it still adds a setup step for developers, and it's a shame to use a JavaScript implementation for code that is actually quite short: https://github.com/mapbox/pixelmatch/blob/main/index.js (and we could even trim the |
Snapshots were moved from "__snapshots__/files" to "__snapshots" in Bacon#206. These two files were moved as well, but their original copies remained due to oversight.
Snapshots were moved from "__snapshots__/files" to "__snapshots__" in Bacon#206. These two files were moved as well, but their original copies remained due to oversight.
Snapshots were moved from "__snapshots__/files" to "__snapshots__" in Bacon#206. These two files were moved as well, but their original copies remained due to oversight.
Snapshots were moved from "__snapshots__/files" to "__snapshots__" in #206. These two files were moved as well, but their original copies remained due to oversight.
No description provided.