Conversation
vlakoff
reviewed
Nov 15, 2025
|
|
||
| protected function getSnapshotId(): string | ||
| { | ||
| $version = mb_substr(\Imagick::getVersion()['versionString'], 12, 1); |
Contributor
There was a problem hiding this comment.
Currently this uses a fixed offset to grab the (assumed one‑digit) major version. You might consider a more robust approach, like:
$versionString = \Imagick::getVersion()['versionString'];
if (!preg_match('/^ImageMagick (\d+)\./', $versionString, $matches)) {
throw new RuntimeException("Unable to extract ImageMagick major version from: {$versionString}");
}
$version = $matches[1];
Contributor
Author
There was a problem hiding this comment.
Thanks. Why does ImageMagick not provide a function like symfony to just get the major version and more details in an array?
I can change it, but first i need to fix the real issue with the failing snapshot
Member
|
Thanks @Chris53897 – I already implemented a proper fix in #206 |
Member
|
Fixed in #206 |
Contributor
Author
|
Thanks @DASPRiD |
Contributor
|
I think this PR attempt effectively showed that managing multiple sets of snapshots would have ended up being too confusing and troublesome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #204 (comment)
snapshots generated on mac
Update: it looks like renaming a file does break the comparing