build(deps): move Pixelmatch from dependencies to devDependencies#216
Merged
DASPRiD merged 1 commit intoBacon:mainfrom Nov 22, 2025
Merged
build(deps): move Pixelmatch from dependencies to devDependencies#216DASPRiD merged 1 commit intoBacon:mainfrom
DASPRiD merged 1 commit intoBacon:mainfrom
Conversation
Pixelmatch is only used in unit tests, so it should be listed under devDependencies. This change ensures: - It still installs with `npm install`, but is skipped with `npm install --production`. - The package.json is more self-documented, clearly indicating Pixelmatch is a dev-only dependency.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=========================================
Coverage 70.81% 70.81%
Complexity 994 994
=========================================
Files 49 49
Lines 3169 3169
=========================================
Hits 2244 2244
Misses 925 925 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vlakoff
added a commit
to vlakoff/BaconQrCode
that referenced
this pull request
Nov 27, 2025
Fixes an oversight in follow-up to Bacon#216, which moved Pixelmatch from dependencies to devDependencies.
Contributor
Author
|
Follow-up PR, fixing an oversight: #219. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A small follow-up to #206.
Moves the Node.js dependency Pixelmatch from
dependenciestodevDependenciesin package.json.Why
npm install, but is skipped when runningnpm install --production.Refs
From this answer on Stack Overflow: