Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions tests/utils_/test_argparse_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -458,22 +458,3 @@ def test_flat_product():
(3, 4, "a", 5, 6),
(3, 4, "b", 5, 6),
]


def test_o_dotted_syntax_error():
"""Test that -O.* dotted syntax raises a clear error message."""
parser = FlexibleArgumentParser()
parser.add_argument("-cc", "--compilation-config", type=json.loads)

# Test that -O.* syntax raises a clear ValueError
with pytest.raises(ValueError, match=r"The -O\.\* syntax is no longer supported"):
parser.parse_args(["-O.backend=eager"])

with pytest.raises(ValueError, match=r"Please use -cc\.\* instead"):
parser.parse_args(["-O.mode=2"])

with pytest.raises(
ValueError,
match=r"replace '-O\.cudagraph_mode=NONE' with '-cc\.cudagraph_mode=NONE'",
):
parser.parse_args(["-O.cudagraph_mode=NONE"])
7 changes: 0 additions & 7 deletions vllm/utils/argparse_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,13 +244,6 @@ def repl(match: re.Match) -> str:
else:
key = pattern.sub(repl, arg, count=1)
processed_args.append(key)
elif arg.startswith("-O."):
# Provide clear error for deprecated -O.* syntax
raise ValueError(
f"The -O.* syntax is no longer supported. "
f"Please use -cc.* instead. "
f"For example, replace '{arg}' with '{arg.replace('-O', '-cc', 1)}'"
)
elif arg.startswith("-O") and arg != "-O":
# allow -O flag to be used without space, e.g. -O3 or -Odecode
# also handle -O=<optimization_level> here
Expand Down