[Frontend] Remove confusing -O.xx flag error #30169
Open
+0
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
gmagogsfm
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes a confusing error message for the deprecated -O.xx command-line flag by removing its special handling. This allows the standard argument parser to handle invalid values, which is a cleaner approach. The corresponding test is also removed. The changes are correct and improve the user experience by providing less confusing error messages. I have no further comments.
Contributor
Author
|
@hmellor Hi, please see this PR for removing the confusing error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error is confusing because -O.xx is too similar to -On which might confuse people. e.g. if a user does -O.2 thinking they're setting optimisation level but then they see an error suggesting they do -cc.2 which also won't work.
More context:
#29991 (comment)