-
Notifications
You must be signed in to change notification settings - Fork 14
S 184653 implemented view submissions for design #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xkurnx
wants to merge
21
commits into
dev
Choose a base branch
from
S-184653-view-design-submissions-final
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
132fb53
merging part 1
xkurnx 0d11b45
merge JS & CSS
xkurnx 9017c78
hide download an view counter until API ready
xkurnx 9fbccc5
link handle
xkurnx a9705cf
merge & and cleanup challenge-detail-software.js
xkurnx 8b72eed
Hide Checkpoint submission on Submission tabs, old site also does no…
xkurnx 100052a
disable clickable on thubmnail until single view ready
xkurnx 0a55edf
revert back challenge-detail-software.js
xkurnx 76dfeab
added submission as box slider on mobile view
xkurnx dbeb8ca
added pagination and missing vars
xkurnx 898ab8a
fix page-challenge-details.php
xkurnx 2e1a90c
added page-challenge-details-header.php
xkurnx 379222d
revert back script-register.json
xkurnx a12f9ca
clean up challenge-detail-software.css again
xkurnx 9ead7fe
deleted page-challenge-details-header.php since content-basic.php has…
xkurnx ee0558c
Clean up challenge-detail-software.css again
xkurnx f35b96e
mergen & clean up challenge-detail-software.js
xkurnx ef35915
revert back scripts.js
xkurnx 3a49e12
merge footer.php
xkurnx 0ad8900
removed unwanted alert
xkurnx cda8070
add index onto submissions list
xkurnx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a hard coded link to a submission?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@indytechcook , it will not be displayed for now. it should be on modal window. but since API / doc was beingdeveloped, i asked member to hardcoded it. SubmissionID would be from API later (next story - https://appirio-community.force.com/cmc/a4150000000ET0D?fId=0D5500000156sniD), and maybe will be rendered by Javascript instead of PHP since it require authentication.
this modal window should be displayed if user click magnifier icons. but for now i just linked to old site