S 184653 implemented view submissions for design #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xkurnx
commented
May 11, 2014
xkurnx
commented
- added submission tabs content would list thumbnails of submissions
- single view submission will be on next challenge
… been created by another challenge
Contributor
There was a problem hiding this comment.
Is this a hard coded link to a submission?
Contributor
Author
There was a problem hiding this comment.
@indytechcook , it will not be displayed for now. it should be on modal window. but since API / doc was beingdeveloped, i asked member to hardcoded it. SubmissionID would be from API later (next story - https://appirio-community.force.com/cmc/a4150000000ET0D?fId=0D5500000156sniD), and maybe will be rendered by Javascript instead of PHP since it require authentication.
this modal window should be displayed if user click magnifier icons. but for now i just linked to old site
Contributor
|
@xkurnx just use this branch when you add on the results for the other challenge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.