Conversation
|
|
Member
|
Thanks! Did quick glance and approved CI, will set aside time to do deeper review soon. |
cretz
reviewed
Feb 3, 2026
Member
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
Looks great, only a couple of minor suggestions
| svc => svc.SayHello(new IHelloService.HelloInput(name, lang)), | ||
| new NexusOperationOptions | ||
| { | ||
| CancellationType = NexusOperationCancellationType.WaitCancellationRequested, |
Member
There was a problem hiding this comment.
May deserve the similar comments here (and elsewhere) similar to the Go and Java samples
Contributor
Author
There was a problem hiding this comment.
Added comments that follow the other samples.
| // Wait for all other operations to complete. | ||
| await Workflow.WhenAllAsync(tasks); | ||
| } | ||
| catch (Exception ex) when (TemporalException.IsCanceledException(ex)) |
Member
There was a problem hiding this comment.
When is this catch triggered in a WhenAllAsync situation for this sample? I think it makes more sense to loop over the tasks waiting for their results individually.
Contributor
Author
There was a problem hiding this comment.
Yea that worked out much better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adds a NexusCancellation sample for the dotnet samples project
Why?
NexusCancellation was requested similar to Go and Java samples
Checklist
Closes Sample request: Nexus cancellation #106
How was this tested:
Manually and Unit Tests.
Similar to the Go/Java samples the caller uses
WaitCancellationRequestedCancellationType.Any docs updates needed?
Updated README with reference to NexusCancellation sample and added README to the sample.