Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview links
|
jsundai
reviewed
Feb 5, 2026
| It's okay to leave operations running in some use cases. | ||
| To ensure cancellations are delivered, wait for all pending operations to finish before exiting the Workflow. | ||
|
|
||
| TODO See the [Nexus cancelation sample](https://github.com/temporalio/samples-java/tree/main/core/src/main/java/io/temporal/samples/nexuscancellation) for reference. |
Contributor
There was a problem hiding this comment.
I think we could we could remove the TODO and change cancelation to cancellation? Otherwise, LGTM!!
Contributor
Author
There was a problem hiding this comment.
Done, also linked to the new sample
Quinn-With-Two-Ns
force-pushed
the
SDK-4370
branch
from
6d8ad24 to
0ab2919
Compare
jsundai
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update docs for Nexus Cancellation for Dotnet to align with Go and Java now that Dotnet's latest release supports cancellation types for Nexus operations
Notes to reviewers
I will wait to merge this PR until temporalio/samples-dotnet#124 is merged so I can link to the sample like Go and Java did.
┆Attachments: EDU-5872 Update docs for Nexus Cancellation for dotnet