Add docs for cancellation types to Python#4207
Add docs for cancellation types to Python#4207Quinn-With-Two-Ns wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📖 Docs PR preview links
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7cd0aae0cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| It's okay to leave operations running in some use cases. | ||
| To ensure cancellations are delivered, wait for all pending operations to finish before exiting the Workflow. | ||
|
|
||
| See the [Nexus cancellation sample](https://github.com/temporalio/samples-dotnet/tree/main/src/NexusCancellation) for reference. |
There was a problem hiding this comment.
This page documents Python Nexus cancellation behavior, but the new reference link sends readers to the .NET sample, which uses different SDK types and option names. In practice, Python users following this section will land on code they cannot directly apply, making the new cancellation guidance harder to validate and likely causing confusion when they try to map cancellation_type to .NET APIs.
Useful? React with 👍 / 👎.
2 participants
What does this PR do?
Add docs for Nexus cancellation types to Python like we did for dotnet #4178
Notes to reviewers
Note this PR needs temporalio/samples-python#276 to merge first and to update the link to the sample
┆Attachments: EDU-5905 Add docs for cancellation types to Python