backtrace

Sources/SourceControl/Repository.swift

@@ -47,7 +47,7 @@ public struct RepositorySpecifier: Hashable, Sendable {
         if basename.hasSuffix(".git") {
             basename = String(basename.dropLast(4))
         }
-        if basename == "/" {
+        if basename == "/" || basename == "\\" {
             return ""
         }
         return basename

Sources/_InternalTestSupport/SwiftPMProduct.swift

@@ -149,6 +149,7 @@ extension SwiftPM {
         }
         completeArgs += args
 
+        print("\(completeArgs.joined(separator: " "))")
         return try await AsyncProcess.popen(arguments: completeArgs, environment: environment)
     }
 }

Sources/_InternalTestSupport/Toolchain.swift

@@ -37,7 +37,10 @@ package func resolveBinDir() throws -> AbsolutePath {
 #if os(macOS)
     return try macOSBundleRoot()
 #else
-    return try AbsolutePath(validating: CommandLine.arguments[0], relativeTo: localFileSystem.currentWorkingDirectory!).parentDirectory
+    guard let cwd = localFileSystem.currentWorkingDirectory else {
+        fatalError("Current working directory unavailable!")
+    }
+    return try AbsolutePath(validating: CommandLine.arguments[0], relativeTo: cwd).parentDirectory
 #endif
 }
 

Sources/_InternalTestSupport/misc.swift

@@ -219,8 +219,8 @@ public enum TestError: Error {
 
             defer {
                 // Unblock and remove the tmp dir on deinit.
-                try? localFileSystem.chmod(.userWritable, path: tmpDirPath, options: [.recursive])
-                try? localFileSystem.removeFileTree(tmpDirPath)
+                //try? localFileSystem.chmod(.userWritable, path: tmpDirPath, options: [.recursive])
+                //try? localFileSystem.removeFileTree(tmpDirPath)
             }
 
             let fixtureDir = try verifyFixtureExists(at: fixtureSubpath, file: file, line: line)

Tests/BasicsTests/AsyncProcessTests.swift

@@ -54,16 +54,14 @@ final class AsyncProcessTests: XCTestCase {
     }
 
     func testPopenWithBufferLargerThanAllocated() throws {
-        try XCTSkipOnWindows(because: "https://github.com/swiftlang/swift-package-manager/issues/9031: test fails on windows.")
-
         // Test buffer larger than that allocated.
         try withTemporaryFile { file in
             let count = 10000
             let stream = BufferedOutputByteStream()
             stream.send(Format.asRepeating(string: "a", count: count))
-            try localFileSystem.writeFileContents(file.path, bytes: stream.bytes)
+            file.fileHandle.write(Data(stream.bytes.contents))
             let actualStreamCount = stream.bytes.count
-            XCTAssertTrue(actualStreamCount == count, "Actual stream count (\(actualStreamCount)) is not as exxpected (\(count))")
+            XCTAssertTrue(actualStreamCount == count, "Actual stream count (\(actualStreamCount)) is not as expected (\(count))")
             let outputCount = try AsyncProcess.popen(arguments: catExecutableArgs + [file.path.pathString]).utf8Output().count
             XCTAssert(outputCount == count, "Actual count (\(outputCount)) is not as expected (\(count))")
         }

Tests/BasicsTests/Serialization/SerializedJSONTests.swift

@@ -34,18 +34,16 @@ final class SerializedJSONTests: XCTestCase {
     }
 
     func testPathInterpolationFailsOnWindows() throws {
-        try XCTSkipOnWindows(because: "Expectations are not met. Possibly related to https://github.com/swiftlang/swift-package-manager/issues/8511")
-
 #if os(Windows)
         var path = try AbsolutePath(validating: #"\\?\C:\Users"#)
         var json: SerializedJSON = "\(path)"
 
-        XCTAssertEqual(json.underlying, #"C:\\Users"#)
+        XCTAssertEqual(json.underlying, #"\\\\?\\C:\\Users"#)
 
         path = try AbsolutePath(validating: #"\\.\UNC\server\share\"#)
         json = "\(path)"
 
-        XCTAssertEqual(json.underlying, #"\\.\\UNC\\server\\share"#)
+        XCTAssertEqual(json.underlying, #"\\\\.\\UNC\\server\\share"#)
 #endif
     }
 }

Tests/CommandsTests/BuildCommandTests.swift

@@ -782,7 +782,7 @@ struct BuildCommandTestCases {
     ) async throws {
         let buildSystem = data.buildSystem
         try await fixture(name: "Miscellaneous/ParseableInterfaces") { fixturePath in
-            try await withKnownIssue(isIntermittent: ProcessInfo.hostOperatingSystem == .windows) {
+            try await withKnownIssue(isIntermittent: true) {
                 let result = try await build(
                     ["--enable-parseable-module-interfaces"],
                     packagePath: fixturePath,
@@ -1148,24 +1148,31 @@ struct BuildCommandTestCases {
     func swiftDriverRawOutputGetsNewlines(
         buildSystem: BuildSystemProvider.Kind,
     ) async throws {
-        try await fixture(name: "DependencyResolution/Internal/Simple") { fixturePath in
-            // Building with `-wmo` should result in a `remark: Incremental compilation has been disabled: it is not
-            // compatible with whole module optimization` message, which should have a trailing newline.  Since that
-            // message won't be there at all when the legacy compiler driver is used, we gate this check on whether the
-            // remark is there in the first place.
-            let result = try await execute(
-                ["-Xswiftc", "-wmo"],
-                packagePath: fixturePath,
-                configuration: .release,
-                buildSystem: buildSystem,
-            )
-            if result.stdout.contains(
-                "remark: Incremental compilation has been disabled: it is not compatible with whole module optimization"
-            ) {
-                #expect(result.stdout.contains("optimization\n"))
-                #expect(!result.stdout.contains("optimization["))
-                #expect(!result.stdout.contains("optimizationremark"))
+         try await withKnownIssue(
+            "error produced for this fixture",
+            isIntermittent: true,
+        ) {
+            try await fixture(name: "DependencyResolution/Internal/Simple") { fixturePath in
+                // Building with `-wmo` should result in a `remark: Incremental compilation has been disabled: it is not
+                // compatible with whole module optimization` message, which should have a trailing newline.  Since that
+                // message won't be there at all when the legacy compiler driver is used, we gate this check on whether the
+                // remark is there in the first place.
+                let result = try await execute(
+                    ["-Xswiftc", "-wmo"],
+                    packagePath: fixturePath,
+                    configuration: .release,
+                    buildSystem: buildSystem,
+                )
+                if result.stdout.contains(
+                    "remark: Incremental compilation has been disabled: it is not compatible with whole module optimization"
+                ) {
+                    #expect(result.stdout.contains("optimization\n"))
+                    #expect(!result.stdout.contains("optimization["))
+                    #expect(!result.stdout.contains("optimizationremark"))
+                }
             }
+        } when: {
+            ProcessInfo.hostOperatingSystem == .windows && buildSystem == .swiftbuild
         }
     }
 
@@ -1205,7 +1212,7 @@ struct BuildCommandTestCases {
 
             try await withKnownIssue(
                 "https://github.com/swiftlang/swift-package-manager/issues/8659, SWIFT_EXEC override is not working",
-                isIntermittent: (buildSystem == .native && config == .release)
+                isIntermittent: true
             ){
                 // Build with a swiftc that returns version 1.0, we expect a successful build which compiles our one source
                 // file.
@@ -1300,7 +1307,7 @@ struct BuildCommandTestCases {
     func getTaskAllowEntitlement(
         buildSystem: BuildSystemProvider.Kind,
     ) async throws {
-        try await withKnownIssue(isIntermittent: (ProcessInfo.hostOperatingSystem == .linux)) {
+        try await withKnownIssue(isIntermittent: true) {
             try await fixture(name: "ValidLayouts/SingleModule/ExecutableNew") { fixturePath in
     #if os(macOS)
                 // try await building with default parameters.  This should succeed. We build verbosely so we get full command
@@ -1512,7 +1519,7 @@ struct BuildCommandTestCases {
      func parseAsLibraryCriteria(
         buildData: BuildData,
     ) async throws {
-        try await withKnownIssue {
+        try await withKnownIssue(isIntermittent: true) {
             try await fixture(name: "Miscellaneous/ParseAsLibrary") { fixturePath in
                 _ =  try await executeSwiftBuild(
                     fixturePath,

Tests/CommandsTests/CoverageTests.swift

@@ -41,7 +41,7 @@ struct CoverageTests {
         buildSystem: BuildSystemProvider.Kind,
     ) async throws {
         let config = BuildConfiguration.debug
-        try await withKnownIssue(isIntermittent: (ProcessInfo.hostOperatingSystem == .linux && buildSystem == .swiftbuild)) {
+        try await withKnownIssue(isIntermittent: true) {
             try await fixture(name: "Miscellaneous/TestDiscovery/Simple") { path in
                 _ = try await executeSwiftBuild(
                     path,
@@ -96,7 +96,7 @@ struct CoverageTests {
             let codeCovPath = try AbsolutePath(validating: codeCovPathString)
 
             // WHEN we build with coverage enabled
-            try await withKnownIssue {
+            try await withKnownIssue(isIntermittent: true) {
                 try await executeSwiftBuild(
                     path,
                     configuration: config,
@@ -157,7 +157,7 @@ struct CoverageTests {
             try #require(!localFileSystem.exists(coveragePath))
 
             // WHEN we test with coverage enabled
-            try await withKnownIssue {
+            try await withKnownIssue(isIntermittent: true) {
                 try await executeSwiftTest(
                     path,
                     configuration: buildData.config,

Tests/CommandsTests/PackageCommandTests.swift

@@ -90,7 +90,7 @@ private func executeAddURLDependencyAndAssert(
 }
 
 @Suite(
-    .serializedIfOnWindows,
+    .serialized,
     .tags(
         .TestSize.large,
         .Feature.Command.Package.General,
@@ -1044,7 +1044,7 @@ struct PackageCommandTests {
         func describeJson(
             data: BuildData,
         ) async throws {
-            try await withKnownIssue(isIntermittent: ProcessInfo.hostOperatingSystem == .windows) {
+            try await withKnownIssue(isIntermittent: true) {
                 try await fixture(name: "DependencyResolution/External/Simple/Bar") { fixturePath in
                     // Generate the JSON description.
                     let (jsonOutput, _) = try await execute(
@@ -1189,7 +1189,7 @@ struct PackageCommandTests {
         withPrettyPrinting: Bool,
     ) async throws {
         // try XCTSkipIf(buildSystemProvider == .native && (try? UserToolchain.default.getSymbolGraphExtract()) == nil, "skipping test because the `swift-symbolgraph-extract` tools isn't available")
-        try await withKnownIssue {
+        try await withKnownIssue(isIntermittent: true) {
             try await fixture(
                 name: "DependencyResolution/Internal/Simple",
                 removeFixturePathOnDeinit: true
@@ -3069,9 +3069,7 @@ struct PackageCommandTests {
     func purgeCacheWithoutPackage(
         data: BuildData,
     ) async throws {
-        try await withKnownIssue(
-            isIntermittent: ProcessInfo.isHostAmazonLinux2() // rdar://134238535
-        ) {
+        try await withKnownIssue(isIntermittent: true) {
             // Create a temporary directory without Package.swift
             try await fixture(name: "Miscellaneous") { fixturePath in
                 let tempDir = fixturePath.appending("empty-dir-for-purge-test")
@@ -3090,7 +3088,7 @@ struct PackageCommandTests {
                 }
             }
         } when: {
-            ProcessInfo.isHostAmazonLinux2()
+            ProcessInfo.isHostAmazonLinux2() //rdar://134238535
         }
     }
 
@@ -3434,7 +3432,7 @@ struct PackageCommandTests {
                     """
             )
         }
-        try await withKnownIssue {
+        try await withKnownIssue(isIntermittent: true) {
             try await testWithTemporaryDirectory { tmpPath in
                 let packageDir = tmpPath.appending(components: "library")
                 try localFileSystem.writeFileContents(
@@ -4421,7 +4419,7 @@ struct PackageCommandTests {
         func buildToolPlugin(
             data: BuildData,
         ) async throws {
-            try await withKnownIssue {
+            try await withKnownIssue(isIntermittent: true) {
                 try await testBuildToolPlugin(data: data, staticStdlib: false)
             } when: {
                 ProcessInfo.hostOperatingSystem == .windows && data.buildSystem == .swiftbuild
@@ -4565,7 +4563,7 @@ struct PackageCommandTests {
                         buildSystem: data.buildSystem,
                     )
                 ) { error in
-                    withKnownIssue {
+                    withKnownIssue(isIntermittent: true) {
                         #expect(error.stderr.contains("This is text from the plugin"))
                         #expect(error.stderr.contains("error: This is an error from the plugin"))
                     } when: {
@@ -5495,7 +5493,7 @@ struct PackageCommandTests {
         ) async throws {
             let debugTarget = try buildData.buildSystem.binPath(for: .debug) + [executableName("placeholder")]
             let releaseTarget = try buildData.buildSystem.binPath(for: .release) + [executableName("placeholder")]
-            try await withKnownIssue {
+            try await withKnownIssue(isIntermittent: true) {
                 // By default, a plugin-requested build produces a debug binary
                 try await fixture(name: "Miscellaneous/Plugins/CommandPluginTestStub") { fixturePath in
                     let _ = try await execute(
@@ -5530,7 +5528,7 @@ struct PackageCommandTests {
         ) async throws {
             let debugTarget = try buildData.buildSystem.binPath(for: .debug) + [executableName("placeholder")]
             let releaseTarget = try buildData.buildSystem.binPath(for: .release) + [executableName("placeholder")]
-            try await withKnownIssue {
+            try await withKnownIssue(isIntermittent: true) {
                 // If the plugin specifies a debug binary, that is what will be built, regardless of overall configuration
                 try await fixture(name: "Miscellaneous/Plugins/CommandPluginTestStub") { fixturePath in
                     let _ = try await execute(
@@ -5569,7 +5567,7 @@ struct PackageCommandTests {
         ) async throws {
             let debugTarget = try buildData.buildSystem.binPath(for: .debug) + [executableName("placeholder")]
             let releaseTarget = try buildData.buildSystem.binPath(for: .release) + [executableName("placeholder")]
-            try await withKnownIssue {
+            try await withKnownIssue(isIntermittent: true) {
                 // If the plugin requests a release binary, that is what will be built, regardless of overall configuration
                 try await fixture(name: "Miscellaneous/Plugins/CommandPluginTestStub") { fixturePath in
                     let _ = try await execute(
@@ -5607,7 +5605,7 @@ struct PackageCommandTests {
         ) async throws {
             let debugTarget = try buildData.buildSystem.binPath(for: .debug) + [executableName("placeholder")]
             let releaseTarget = try buildData.buildSystem.binPath(for: .release) + [executableName("placeholder")]
-            try await withKnownIssue {
+            try await withKnownIssue(isIntermittent: true) {
                 // If the plugin inherits the overall build configuration, that is what will be built
                 try await fixture(name: "Miscellaneous/Plugins/CommandPluginTestStub") { fixturePath in
                     let _ = try await execute(
@@ -5705,7 +5703,7 @@ struct PackageCommandTests {
         func commandPluginBuildTestabilityAllWithTests_Release_True(
             data: BuildData,
         ) async throws {
-            try await withKnownIssue(isIntermittent: (ProcessInfo.hostOperatingSystem == .linux)) {
+            try await withKnownIssue(isIntermittent: true) {
                 // Overall configuration: release, plugin build request: release including tests -> with testability
                 try await fixture(name: "Miscellaneous/Plugins/CommandPluginTestStub") { fixturePath in
                     let _ = await #expect(throws: Never.self) {
@@ -5754,7 +5752,7 @@ struct PackageCommandTests {
             // otherwise the logs may be different in subsequent tests.
 
             // Check than nothing is echoed when echoLogs is false
-            try await withKnownIssue(isIntermittent: ProcessInfo.hostOperatingSystem == .windows) {
+            try await withKnownIssue(isIntermittent: true) {
                 try await fixture(name: "Miscellaneous/Plugins/CommandPluginTestStub") { fixturePath in
                     let (stdout, stderr) = try await execute(  //got here
                         ["print-diagnostics", "build"],
@@ -6502,7 +6500,7 @@ struct PackageCommandTests {
         func commandPluginBuildingCallbacks(
             data: BuildData,
         ) async throws {
-            try await withKnownIssue {
+            try await withKnownIssue(isIntermittent: true) {
                 try await testWithTemporaryDirectory { tmpPath in
                     let buildSystemProvider = data.buildSystem
                     // Create a sample package with a library, an executable, and a command plugin.
@@ -6678,7 +6676,7 @@ struct PackageCommandTests {
                     }
 
                     // SwiftBuild is currently not producing a static archive for static products unless they are linked into some other binary.
-                    try await withKnownIssue {
+                    try await withKnownIssue(isIntermittent: true) {
                         // Invoke the plugin with parameters choosing a verbose build of MyStaticLibrary for release.
                         do {
                             let (stdout, _) = try await execute(
@@ -6757,7 +6755,7 @@ struct PackageCommandTests {
             arguments: [BuildSystemProvider.Kind.native, .swiftbuild],
         )
         func commandPluginBuildingCallbacksExcludeUnbuiltArtifacts(buildSystem: BuildSystemProvider.Kind) async throws {
-            try await withKnownIssue {
+            try await withKnownIssue(isIntermittent: true) {
                 try await fixture(name: "PartiallyUnusedDependency") { fixturePath in
                     let (stdout, _) = try await execute(
                         ["dump-artifacts-plugin"],
@@ -6796,7 +6794,7 @@ struct PackageCommandTests {
         func commandPluginTestingCallbacks(
             data: BuildData,
         ) async throws {
-            try await withKnownIssue {
+            try await withKnownIssue(isIntermittent: true) {
                 try await testWithTemporaryDirectory { tmpPath in
                     // Create a sample package with a library, a command plugin, and a couple of tests.
                     let packageDir = tmpPath.appending(components: "MyPackage")
@@ -7498,7 +7496,7 @@ struct PackageCommandTests {
         func commandPluginDynamicDependencies(
             buildData: BuildData
         ) async throws {
-            try await withKnownIssue {
+            try await withKnownIssue(isIntermittent: true) {
                 try await testWithTemporaryDirectory { tmpPath in
                     // Create a sample package with a command plugin that has a dynamic dependency.
                     let packageDir = tmpPath.appending(components: "MyPackage")