backtrace #9516
backtrace #9516
Conversation
|
@swift-ci test windows self hosted |
|
@swift-ci test windows |
- also mark withKnownIssues tests as isIntermittent: true so that as we fix things in dependent packages (like swift-build) we don't break swiftPM CI - serializing some test that change cwd to hopefully fix the AL2 crashes where the CWD has been deleted and calls to get CWD returns nil
jakepetroules
force-pushed
the
backtrace
branch
from
0644ac0 to
dbb5363
Compare
| #expect(result.stdout.contains("optimization\n")) | ||
| #expect(!result.stdout.contains("optimization[")) | ||
| #expect(!result.stdout.contains("optimizationremark")) | ||
| try await withKnownIssue( |
There was a problem hiding this comment.
issue: this is a regression. the test was passing on Windows, and not it no longer is. do we know what caused this? Can we add a test in SwiftBuild to prevent this regression?
| } | ||
| } when: { | ||
| ProcessInfo.isHostAmazonLinux2() | ||
| ProcessInfo.isHostAmazonLinux2() //rdar://134238535 |
There was a problem hiding this comment.
do we have a GitHub issue instead of a radar link?
Also, can we add said issue as a .bug(...) trait?
| configuration: BuildConfiguration, | ||
| ) async throws { | ||
| try await withKnownIssue("Failes to find test executable") { | ||
| try await withKnownIssue("Failes to find test executable, or getting error: module 'Simple' was not compiled for testing, onMacOS", isIntermittent: true) { |
There was a problem hiding this comment.
issue: The withKnownIssues where conditionalized based on configuration and swiftBuild, but we are know unconditionally expecting an intermittent failure.
This removes the visibility into which conditions passes, and which are actually intermittent. Can we re-add the when: closure associated with the test so we have better understanding of what needs to be fixed when it's time to remove the withKnownIssues
| extraArgs: ["--build-system=swiftbuild"], | ||
| env: ["SWIFT_DRIVER_SWIFTSCAN_LIB" : "/this/is/a/bad/path"], | ||
| buildSystem: .native, | ||
| buildSystem: .swiftbuild, |
There was a problem hiding this comment.
issue: in order to ensure we don't regress on native build systems, can we add that test back in?
|
|
||
| final class ResourcesTests: XCTestCase { | ||
| func testSimpleResources() async throws { | ||
| try XCTSkipOnWindows( |
There was a problem hiding this comment.
praise: glad to see more tests being enabled.
|
|
||
| @Test( | ||
| .IssueWindowsPathTestsFailures, | ||
| .disabled("Requires swift-testing bug fix https://github.com/swiftlang/swift-testing/pull/1441"), |
There was a problem hiding this comment.
question: Do we really need to disabled this test? Can we instead guard this based on compiler version? For example, see the requireSwift6_2 trait
| } | ||
| try expectDiagnostics(observability.diagnostics) { results in | ||
| results.checkIsEmpty() | ||
| try await withKnownIssue("https://github.com/swiftlang/swift-package-manager/issues/8543: there are compilation errors on Windows", isIntermittent: true) { |
There was a problem hiding this comment.
suggestion: can we apply a .issue("https://github.com/swiftlang/swift-package-manager/issues/8543", relationship: .defect) trait on the test?
|
|
||
| final class RegistryPackageContainerTests: XCTestCase { | ||
|
|
||
| override func setUpWithError() throws { |
There was a problem hiding this comment.
praise: great to see this.
|
|
||
| final class SourceControlPackageContainerTests: XCTestCase { | ||
| func testVprefixVersions() async throws { | ||
| try XCTSkipOnWindows(because: """ |
There was a problem hiding this comment.
praise: great to see this.
also mark withKnownIssues tests as isIntermittent: true so that as we fix things in dependent packages (like swift-build) we don't break swiftPM CI
serializing some test that change cwd to hopefully fix the AL2 crashes where the CWD has been deleted and calls to get CWD returns nil
[One line description of your change]
Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Result:
[After your change, what will change.]