Switch to boost-crc for checksum computation#8
Merged
polymerizedsage merged 1 commit intomainfrom Jan 10, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #7 . This does change the parameters of the CRC function to the defaults for boost crc16. I figure we arent particularly picky about what variant we are using.
Benchmarked by measuring the average time to calculate the CRC16 for a NDTP broadband packet with 1000 12-bit samples from one channel (1526 bytes). Benchmarks were run 128000 iterations to get an average execution time.
Old implementation: ~85 us per packet
Boost implementation: ~5.12 us per packet
Tests were run locally on Intel i9-13900H