✨ collect scene nodes recursively #217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schell
requested changes
Dec 21, 2025
Owner
schell
left a comment
schell
left a comment
There was a problem hiding this comment.
Thank you for the PR 🙇 ! I just had a quick suggestion about how to make the difference between the root nodes and recursively collected nodes more explicit.
| } | ||
| } | ||
|
|
||
| pub fn nodes_in_scene(&self, scene_index: usize) -> impl Iterator<Item = &GltfNode> { |
Owner
There was a problem hiding this comment.
This function is lacking documentation, which is my fault. It should mention that this function roughly follows the gltf::Scene::nodes function.
I think what we need here is a new pub recursive_nodes_in_scene(&self, scene_index: usize) -> impl Iterator<Item = &GltfNode>, and maybe we should rename nodes_in_scene to root_nodes_in_scene.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
had a problem trying to animate an object that was parented. the problem was that nodes_in_scene would only collect the nodes referenced by the scene directly (without including their children)