Skip to content

Conversation

@satvshr
Copy link
Contributor

@satvshr satvshr commented Dec 23, 2025


What does this PR implement/fix? Explain your changes.

  • Added Ruff’s local cache directory .ruff_cache to .gitignore.
  • Added .cursorignore and .cursorindexingignore to .gitignore to match the latest official GitHub Python .gitignore template

@satvshr satvshr changed the title [BUG] Update .gitignore [BUG] Update .gitignore Dec 23, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.23%. Comparing base (3380bbb) to head (0808aa4).
⚠️ Report is 154 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1547       +/-   ##
===========================================
- Coverage   85.24%   64.23%   -21.01%     
===========================================
  Files          38       36        -2     
  Lines        5008     4351      -657     
===========================================
- Hits         4269     2795     -1474     
- Misses        739     1556      +817     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fkiraly fkiraly changed the title [BUG] Update .gitignore [MNT] Update .gitignore Dec 30, 2025
@fkiraly fkiraly added the maintenance & CI Continuous integration & package distribution label Dec 30, 2025
@fkiraly fkiraly merged commit 7975eb5 into openml:main Dec 30, 2025
9 checks passed
fkiraly pushed a commit that referenced this pull request Jan 14, 2026
…ruff checks (#1553)

#### Metadata
* Stacks on #1547 (for ignoring `.ruff_cache`)
* Reference Issue: fixes #1550 
* New Tests Added: No
* Documentation Updated: No

#### Details 
What does this PR implement/fix? Explain your changes.
* Updates the ruff version in .pre-commit-config.yaml to 0.14.10
* Runs `ruff format .` to align the codebase with the formatting rules of the updated Ruff version
* Fixes also added to pass `ruff check .` checks
* Add `noqa` tags in places that will end up changing the architecture of the function/class if I try fixing it
* Only changes from my end to the actual code would be changing small things like:
  * the print statements to be compatible with check [UP031](https://docs.astral.sh/ruff/rules/printf-string-formatting/)
  * Changing variable names to `_` to be compatible with [RUF059](https://docs.astral.sh/ruff/rules/unused-unpacked-variable/)

This PR is going to be a bigger one in size but in my opinion, we should be compatible with the latest ruff version and get it over with sooner rather than later.

On a separate note, there are already a significant number of `noqa` tags in the codebase. We should consider revisiting the architecture of the functions and classes that rely on them to better align with Ruff’s best practices. Where alignment isn’t appropriate, we should at least discuss why those components don’t need to be Ruff-compatible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance & CI Continuous integration & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNT] Update .gitignore to include pre-commit and cursor files

3 participants