Skip to content

Conversation

@satvshr
Copy link
Contributor

@satvshr satvshr commented Dec 24, 2025

Metadata

Details

What does this PR implement/fix? Explain your changes.

  • Updates the ruff version in .pre-commit-config.yaml to 0.14.10
  • Runs ruff format . to align the codebase with the formatting rules of the updated Ruff version
  • Fixes also added to pass ruff check . checks
  • Add noqa tags in places that will end up changing the architecture of the function/class if I try fixing it
  • Only changes from my end to the actual code would be changing small things like:
    • the print statements to be compatible with check UP031
    • Changing variable names to _ to be compatible with RUF059

This PR is going to be a bigger one in size but in my opinion, we should be compatible with the latest ruff version and get it over with sooner rather than later.

On a separate note, there are already a significant number of noqa tags in the codebase. We should consider revisiting the architecture of the functions and classes that rely on them to better align with Ruff’s best practices. Where alignment isn’t appropriate, we should at least discuss why those components don’t need to be Ruff-compatible.

@satvshr satvshr marked this pull request as draft December 24, 2025 11:01
@satvshr satvshr marked this pull request as ready for review December 24, 2025 12:29
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 71.05263% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.28%. Comparing base (bd8ae77) to head (c6663e1).

Files with missing lines Patch % Lines
openml/runs/run.py 33.33% 4 Missing ⚠️
openml/runs/functions.py 57.14% 3 Missing ⚠️
openml/config.py 50.00% 2 Missing ⚠️
openml/datasets/data_feature.py 66.66% 1 Missing ⚠️
openml/flows/functions.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1553      +/-   ##
==========================================
+ Coverage   79.14%   79.28%   +0.13%     
==========================================
  Files          36       36              
  Lines        4320     4320              
==========================================
+ Hits         3419     3425       +6     
+ Misses        901      895       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNT] Updating ruff version for pre-commit

3 participants