[SYCLomatic] Fixing dpct::device_vector usage in copy_if test#240
Closed
danhoeflinger wants to merge 2 commits intooneapi-src:SYCLomaticfrom
Closed
[SYCLomatic] Fixing dpct::device_vector usage in copy_if test#240danhoeflinger wants to merge 2 commits intooneapi-src:SYCLomaticfrom
danhoeflinger wants to merge 2 commits intooneapi-src:SYCLomaticfrom
Conversation
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
This was referenced Feb 22, 2023
Contributor
Author
|
Closing this in favor of #243, which includes these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Device vector was used in a way which reached into the underlying pointers and used
queue.memcpy()rather than using its implicit host/device copy functionality. For USM this worked, but for the buffer variety this caused a segfault.This PR changes the usage pattern to match
onedpl_test_vector.cpp, and resolves the crash.This seems to have been a known runtime failure, as there was a comment describing this, which I have removed.