[SYCLomatic] Testing dpct::device_vector zero allocation#234
Merged
zhimingwang36 merged 1 commit intooneapi-src:SYCLomaticfrom Jun 29, 2023
Conversation
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
danhoeflinger
changed the title
zhimingwang36
requested changes
Feb 22, 2023
Contributor
zhimingwang36
left a comment
zhimingwang36
left a comment
There was a problem hiding this comment.
Seem this test case failed.
Contributor
Author
I believe this is an unrelated failure in |
|
@zhimingwang36 would you please confirm #243 resolved the test failure and this PR can be re-approved and merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a test of a size zero dpct::device_vector. Will throw exception until oneapi-src/SYCLomatic#619 is merged.
Fixing some incorrect comments describing expected values for
_Verboseoutput.