This repository was archived by the owner on Mar 6, 2019. It is now read-only.
Update mappings spec to handle 8.2 format#83
Open
zstumgoren wants to merge 21 commits intonytimes:masterfrom
Open
Update mappings spec to handle 8.2 format#83zstumgoren wants to merge 21 commits intonytimes:masterfrom
zstumgoren wants to merge 21 commits intonytimes:masterfrom
Conversation
The `@encoding` instance variable on a `Filing` object is ignored in
methods such as `Filing#form_type`, which can lead to an `ArgumentError`
("invalid byte sequence in UTF-8"). The included test case demonstrates
such an error when we try to call `Filing#summary`.
This change takes `@encoding` into account when reading the filing from
disk, which avoids the `ArgumentError`.
…s-with-encoding Read filing's contents using specified encoding
…b directly in Gemfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blerf. Apologies, should've run
rake fech:test:specbefore I submitted earlier PR! This minor spec tweak returns tests to green.