This repository was archived by the owner on Mar 6, 2019. It is now read-only.
Read filing's contents using specified encoding#86
Open
myersjustinc wants to merge 1 commit intonytimes:masterfrom
Open
Read filing's contents using specified encoding#86myersjustinc wants to merge 1 commit intonytimes:masterfrom
myersjustinc wants to merge 1 commit intonytimes:masterfrom
Conversation
The `@encoding` instance variable on a `Filing` object is ignored in
methods such as `Filing#form_type`, which can lead to an `ArgumentError`
("invalid byte sequence in UTF-8"). The included test case demonstrates
such an error when we try to call `Filing#summary`.
This change takes `@encoding` into account when reading the filing from
disk, which avoids the `ArgumentError`.
Contributor
|
@myersjustinc Thanks for this! I am not sure if the folks at the NYT are still maintaining this, but I've got a fork here and would be happy to have this PR there. |
Author
|
Sounds good. Once I've filed a matching PR on dwillis/Fech, should I also leave this one open on this repo, or should I close this one to avoid confusion? |
Contributor
|
I would leave it open, as I'm unsure whether this repo is actively monitored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@encodinginstance variable on aFilingobject is ignored in methods such asFiling#form_type, which can lead to anArgumentError("invalid byte sequence in UTF-8"). Before the included change inlib/fech/filing.rbis made, the included test case demonstrates such an error when we try to callFiling#summary.This change takes
@encodinginto account when reading the filing from disk, which avoids theArgumentError.(The entire test suite now only has two failing tests, both of which are addressed in #83 and don't appear to be related to this specific change.)