fix(i18n): improve german translation#1085
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis pull request removes the Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
lunaria/files/de-DE.json (1)
822-822:⚠️ Potential issue | 🟡 MinorPotential inconsistency:
account_menu.opsstill uses "Operation(en)".Line 822 reads
"{count} Operation | {count} Operationen"while all other occurrences of "Operation" withinoperations.queue.*have been migrated to "Aktion(en)". If the intent is to replace the anglicism consistently, this key should be updated as well.If there's a deliberate reason to keep "Operation" here (e.g. it refers to npm CLI operations specifically), it might be worth adding a comment in the PR noting that distinction.
Suggested fix
- "ops": "{count} Operation | {count} Operationen", + "ops": "{count} Aktion | {count} Aktionen",
| <NuxtLink | ||
| to="/privacy" | ||
| class="link-subtle font-mono text-xs min-h-11 flex items-center gap-1 lowercase" | ||
| class="link-subtle font-mono text-xs min-h-11 flex items-center gap-1" |
There was a problem hiding this comment.
revert this change, we need to disccuss this, we also have some uppercase usages in headings, or just await core team response
There was a problem hiding this comment.
Thanks for chiming in. I would be fine with uppercase in headings for now, at least regarding German. Lowercase would also be fine if we reeeeally want it, but then the whole footer should be lowercased.
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
i18n/locales/de-DE.json (1)
822-822:⚠️ Potential issue | 🟡 MinorInconsistent terminology:
account_menu.opsstill uses "Operation/Operationen".Line 822 still reads
"{count} Operation | {count} Operationen", but every other occurrence of this term (lines 453–472) has been updated to "Aktion/Aktionen". This should be aligned for consistency.Proposed fix
- "ops": "{count} Operation | {count} Operationen", + "ops": "{count} Aktion | {count} Aktionen",lunaria/files/de-DE.json (1)
822-822:⚠️ Potential issue | 🟡 MinorSame inconsistency as in
i18n/locales/de-DE.json:account_menu.opsstill uses "Operation/Operationen".Should be updated to match the rest of the "Aktion/Aktionen" terminology.
Proposed fix
- "ops": "{count} Operation | {count} Operationen", + "ops": "{count} Aktion | {count} Aktionen",
|
Awesome enhancements. I know it's closed already, but why did you replace all "Operationen" with "Aktionen". IMHO "Operationen" fits much better. Idk, for me all the phrases read somehow weird with "Aktionen". Would you (@essenmitsosse ) be so kind and give a little bit more reasoning for your idea regarding this? I'd like to just understand it better 👍 |
|
@trueberryless i didn't even notice this was closed already. Saw it more as a suggestion and wanted to hear some feedback. Honestly we can just roll it back, I'm not really stuck on it. |
|
Thanks for the quick reply and feedback. I think I might revert it then - or you, whoever does the next translation |
Before ("datenschutzerklärung" needs to be capitalized):

@userquin: could you check if there was a specific reason for lower casing this word via CSS? Don't want to break any other language
edit: Also updated the tagline to the new version and made sure we don't get unnecessary line wrapping.