Skip to content

fix(i18n): improve german translation#1085

Merged
danielroe merged 5 commits intonpmx-dev:mainfrom
essenmitsosse:improve-german-translation
Feb 6, 2026
Merged

fix(i18n): improve german translation#1085
danielroe merged 5 commits intonpmx-dev:mainfrom
essenmitsosse:improve-german-translation

Conversation

@essenmitsosse
Copy link
Contributor

@essenmitsosse essenmitsosse commented Feb 6, 2026

  • Removes a few anglicisms
  • Fixes wrong casing for german footer

Before ("datenschutzerklärung" needs to be capitalized):
Screenshot 2026-02-06 at 11 34 23

@userquin: could you check if there was a specific reason for lower casing this word via CSS? Don't want to break any other language

edit: Also updated the tagline to the new version and made sure we don't get unnecessary line wrapping.

@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 6, 2026 1:12pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 6, 2026 1:12pm
npmx-lunaria Ignored Ignored Feb 6, 2026 1:12pm

Request Review

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/de-DE.json Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

This pull request removes the lowercase CSS class from the privacy NuxtLink in AppFooter.vue, increases the home page paragraph max width from max-w-md to max-w-xl, and updates German translations in two locale files to prefer terms like “Aktion/ Aktionen” over “Operation/ Operationen”, replace “Log” with “Protokoll”, and adjust phrasing (e.g., “Features” → “Funktionen”, and “besserer Browser” → “schnellerer, modernerer Browser”). No control-flow, data-handling, or public/exported declarations were changed.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately describes the changeset, addressing German translation improvements including anglicism removal, CSS casing fix for 'datenschutzerklärung', tagline updates, and line wrapping prevention.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
lunaria/files/de-DE.json (1)

822-822: ⚠️ Potential issue | 🟡 Minor

Potential inconsistency: account_menu.ops still uses "Operation(en)".

Line 822 reads "{count} Operation | {count} Operationen" while all other occurrences of "Operation" within operations.queue.* have been migrated to "Aktion(en)". If the intent is to replace the anglicism consistently, this key should be updated as well.

If there's a deliberate reason to keep "Operation" here (e.g. it refers to npm CLI operations specifically), it might be worth adding a comment in the PR noting that distinction.

Suggested fix
-    "ops": "{count} Operation | {count} Operationen",
+    "ops": "{count} Aktion | {count} Aktionen",

<NuxtLink
to="/privacy"
class="link-subtle font-mono text-xs min-h-11 flex items-center gap-1 lowercase"
class="link-subtle font-mono text-xs min-h-11 flex items-center gap-1"
Copy link
Contributor

@userquin userquin Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this change, we need to disccuss this, we also have some uppercase usages in headings, or just await core team response

Copy link
Contributor Author

@essenmitsosse essenmitsosse Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for chiming in. I would be fine with uppercase in headings for now, at least regarding German. Lowercase would also be fine if we reeeeally want it, but then the whole footer should be lowercased.

@essenmitsosse essenmitsosse changed the title Improve german translation i18n: improve german translation Feb 6, 2026
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)
i18n/locales/de-DE.json (1)

822-822: ⚠️ Potential issue | 🟡 Minor

Inconsistent terminology: account_menu.ops still uses "Operation/Operationen".

Line 822 still reads "{count} Operation | {count} Operationen", but every other occurrence of this term (lines 453–472) has been updated to "Aktion/Aktionen". This should be aligned for consistency.

Proposed fix
-    "ops": "{count} Operation | {count} Operationen",
+    "ops": "{count} Aktion | {count} Aktionen",
lunaria/files/de-DE.json (1)

822-822: ⚠️ Potential issue | 🟡 Minor

Same inconsistency as in i18n/locales/de-DE.json: account_menu.ops still uses "Operation/Operationen".

Should be updated to match the rest of the "Aktion/Aktionen" terminology.

Proposed fix
-    "ops": "{count} Operation | {count} Operationen",
+    "ops": "{count} Aktion | {count} Aktionen",

@danielroe danielroe changed the title i18n: improve german translation fix(i18n): improve german translation Feb 6, 2026
@danielroe danielroe added this pull request to the merge queue Feb 6, 2026
Merged via the queue into npmx-dev:main with commit 2acb298 Feb 6, 2026
17 of 19 checks passed
@trueberryless
Copy link
Contributor

Awesome enhancements.

I know it's closed already, but why did you replace all "Operationen" with "Aktionen". IMHO "Operationen" fits much better. Idk, for me all the phrases read somehow weird with "Aktionen". Would you (@essenmitsosse ) be so kind and give a little bit more reasoning for your idea regarding this? I'd like to just understand it better 👍

@essenmitsosse
Copy link
Contributor Author

@trueberryless i didn't even notice this was closed already. Saw it more as a suggestion and wanted to hear some feedback. Honestly we can just roll it back, I'm not really stuck on it.

@trueberryless
Copy link
Contributor

trueberryless commented Feb 7, 2026

Thanks for the quick reply and feedback. I think I might revert it then - or you, whoever does the next translation ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants