Skip to content

feat: polish colors and indents#1042

Merged
danielroe merged 7 commits intonpmx-dev:mainfrom
alexdln:feat/polish-colors-and-indents
Feb 6, 2026
Merged

feat: polish colors and indents#1042
danielroe merged 7 commits intonpmx-dev:mainfrom
alexdln:feat/polish-colors-and-indents

Conversation

@alexdln
Copy link
Contributor

@alexdln alexdln commented Feb 5, 2026

Changes (in same order as in changes):

  • Made both the background and text a bit lighter. Previously, too much of it was blending in, and I got a few complaints about it. I tried to maintain the feel of the website as much as possible; it felt like the screen brightness had simply been increased by 10%.
  • Changed the colors in background shades to make them softer and more different
  • Made the header's background transparent using a backing so that I could use backdrop-blur on nested elements (the browser restriction is that you can't use backdrop-blur inside an element with backdrop-blur)
  • Added effects and a clickable area for the chips, since it was 20px and the text was blending in
  • Added effects for fields
  • Changed accountMenu styling - it looked too dirty in the light theme. I softened the tones, added transparency and blur
  • Effects for fields / clickable zone, a bit more space in connector warning between texts
  • Increased clickable zone in modal and changed background to lighter one - the backdrop background should contrast with the modal background, but in our case it blended in a bit in the dark theme
  • Кemoved the extra border under the table view, as there were two borders in a row
  • Fixed text-decoration color on hover in readme
  • Added effects for the active tagradiobutton (and fixed focus to be the same as everywhere else)
  • For versions-selecter and package-docs same as with header and user-menu - was dirty in light, updated colors and added blur
  • Reduced the spacing of the "readme" header and fixed its position
  • Tired to describe it, thanks for reading and reviewing ❤️

Closes #974

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 6, 2026 2:24pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 6, 2026 2:24pm
npmx-lunaria Ignored Ignored Feb 6, 2026 2:24pm

Request Review

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/pages/package/[[org]]/[name].vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

Updates are visual-only: colour tokens in app/assets/main.css were adjusted for dark and light modes and per-theme blocks; several components had utility classes changed or spacing tweaked (notably header, modals, menus, inputs, chips and buttons); header blur was moved from element classes to an absolutely positioned overlay; no functional logic or public APIs were modified.

Possibly related PRs

Suggested reviewers

  • danielroe
  • 43081j
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The PR description clearly relates to the changeset, detailing color and styling refinements across multiple components that match the file-level summaries provided.
Linked Issues check ✅ Passed The pull request addresses the objectives from issue #974 by reducing contrast through colour lightening, softening background shades, adjusting text colours, adding transparency and blur effects, and expanding interactive zones.
Out of Scope Changes check ✅ Passed All changes are within scope: styling adjustments, colour token updates, and spacing refinements directly address the linked issue's objectives without introducing unrelated functionality or logic changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@alexdln
Copy link
Contributor Author

alexdln commented Feb 5, 2026

I love these CIs, 0.96, there was a very weak spot somewhere, I'll check it now

(although it's a shame, since I went through all the pages with Lighthouse)

UPD: it's funny, it failed because it couldn't load a package readme. But anyway it's good, that needs fixing as well

image

UPD: Weird...
image

UPD2: Okay, he got away with the underline. Very weird

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@danielroe danielroe added this pull request to the merge queue Feb 6, 2026
Merged via the queue into npmx-dev:main with commit 3d3fb2a Feb 6, 2026
17 checks passed
@alexdln alexdln deleted the feat/polish-colors-and-indents branch February 6, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: soften areas with too much contrast

2 participants