Skip to content

Aris - combo box #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NeleR wants to merge 3 commits into
base: aris
Choose a base branch
from
Open

Aris - combo box #25

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff02073
fix: when exiting a combo box dropdown, clear the key value (value se…
NeleR Dec 15, 2025
187b21e
fix: select first option in combo box as key value when going inside …
NeleR Dec 15, 2025
3c15900
fix: clear combo box search value after selecting a value
NeleR Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion input/combo2/combo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,9 @@ Vue.component("n-input-combo2", {
this.showValues = true;
}
},
clearKeyValue: function() {
this.keyValue = null
},
initializeKeyValue: function() {
// if you have no key value yet, we just take the first one
if (this.keyValue == null) {
Expand All @@ -324,7 +327,11 @@ Vue.component("n-input-combo2", {
moveKeyValue: function(amount) {
// only relevant if you can see something
this.showValues = true;
this.initializeKeyValue();
if(this.keyValue === null) {
this.initializeKeyValue();
amount = 0; // we just initialised, don't change the index again
}

if (this.keyValue != null) {
var index = this.potentialValues.indexOf(this.keyValue);
index += amount;
Expand Down Expand Up @@ -558,6 +565,7 @@ Vue.component("n-input-combo2", {
},
toggle: function(entry) {
var index = this.rawValues.indexOf(entry);
// this entry was not selected yet
if (index < 0) {
if (!this.multiple) {
this.rawValues.splice(0);
Expand All @@ -568,15 +576,24 @@ Vue.component("n-input-combo2", {
this.showValues = false;
}
}
// this entry was already selected
else {
// we only want to allow deselection if you have at least one other value or it can be reset to nill
if (this.rawValues.length >= 2 || this.nillable) {
this.rawValues.splice(index, 1);
}

// clear the search input when (de)selecting an option
this.search = "";
}
}
},
watch: {
showValues: function(showValues) {
if (showValues === false) {
this.clearKeyValue();
}
},
calculating: function(newValue) {
if (!newValue && !this.initialized) {
if (this.value != null) {
Expand Down