Aris - combo box #25
Open
Aris - combo box #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lected by keyboard navigation) The Key Value did not used to be cleared. So when you exited the combo box and then re-entered, you would continue where you were. That is not what a user would expect. Now we always start at the first item after re-entering the combo box options dropdown.
…the first time, not the second
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds three improvements to the combo box:
The Key Value did not used to be cleared. So when you exited the combo box and then re-entered, you would continue where you were. That is not what a user would expect. Now we always start at the first item after re-entering the combo box options dropdown.
fix: select first option in combo box as key value when going inside the first time, not the second
fix: clear combo box search value after selecting a value