Skip to content

Fix TS generator crash from duplicated reference assemblies #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasongin merged 1 commit into from
Jan 15, 2026
Merged

Fix TS generator crash from duplicated reference assemblies #469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/NodeApi.Generator/TypeDefinitionsGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,10 @@ public static void GenerateTypeDefinitions(
throw new ArgumentNullException(nameof(modulePaths));
}

// Provided reference assemblies may be duplicated when they come from multiple
// places in a complex dependency tree.
referenceAssemblyPaths = referenceAssemblyPaths.Distinct();

// Create a metadata load context that includes a resolver for system assemblies,
// referenced assemblies, and the target assembly.
IEnumerable<string> allReferenceAssemblyPaths = MergeSystemReferenceAssemblies(
Expand Down
Loading