no whole archive #2192
Open
no whole archive #2192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added when we redid bulid but it isn't necessary -- doesn't build shared libraries of intermediate crates, and I don't think things use dynamic lookup of symbols within our rust crate. Lets see if CI passes. Differential Revision: [D89570908](https://our.internmc.facebook.com/intern/diff/D89570908/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D89570908/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Dec 19, 2025
Added when we redid bulid but it isn't necessary -- doesn't build shared libraries of intermediate crates, and I don't think things use dynamic lookup of symbols within our rust crate. Lets see if CI passes. Differential Revision: [D89570908](https://our.internmc.facebook.com/intern/diff/D89570908/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D89570908/)! ghstack-source-id: 330554833 Pull Request resolved: #2192
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Added when we redid bulid but it isn't necessary -- doesn't build shared libraries of intermediate crates, and I don't think things use dynamic lookup of symbols within our rust crate. Lets see if CI passes.
Differential Revision: D89570908
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!