Skip to content

Commit 2f9570e

Browse files
committed
no whole archive
Added when we redid bulid but it isn't necessary -- doesn't build shared libraries of intermediate crates, and I don't think things use dynamic lookup of symbols within our rust crate. Lets see if CI passes. Differential Revision: [D89570908](https://our.internmc.facebook.com/intern/diff/D89570908/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D89570908/)! ghstack-source-id: 330554833 Pull Request resolved: #2192
1 parent dc09a8f commit 2f9570e

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

build_utils/src/lib.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -385,11 +385,8 @@ impl CppStaticLibsConfig {
385385
println!("cargo::rustc-link-search=native={}", self.rdma_lib_dir);
386386
println!("cargo::rustc-link-search=native={}", self.rdma_util_dir);
387387

388-
// Use whole-archive for rdma-core static libraries
389-
println!("cargo::rustc-link-arg=-Wl,--whole-archive");
390388
println!("cargo::rustc-link-lib=static=mlx5");
391389
println!("cargo::rustc-link-lib=static=ibverbs");
392-
println!("cargo::rustc-link-arg=-Wl,--no-whole-archive");
393390

394391
// rdma_util helper library
395392
println!("cargo::rustc-link-lib=static=rdma_util");

monarch_cpp_static_libs/build.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -254,11 +254,8 @@ fn emit_link_directives(rdma_build_dir: &Path) {
254254
);
255255
println!("cargo:rustc-link-search=native={}", rdma_util_dir.display());
256256

257-
// Static libraries - use whole-archive for rdma-core static libraries
258-
println!("cargo:rustc-link-arg=-Wl,--whole-archive");
259257
println!("cargo:rustc-link-lib=static=mlx5");
260258
println!("cargo:rustc-link-lib=static=ibverbs");
261-
println!("cargo:rustc-link-arg=-Wl,--no-whole-archive");
262259

263260
// rdma_util helper library
264261
println!("cargo:rustc-link-lib=static=rdma_util");

0 commit comments

Comments
 (0)