feat: add notes about CAA records to custom domains#665
feat: add notes about CAA records to custom domains#665onderay merged 2 commits intokinde-oss:mainfrom
Conversation
WalkthroughThis PR adds CAA (Certificate Authority Authorization) guidance to domain configuration documentation. Both files receive instructions clarifying that SSL certificate provisioning must authorize ZeroSSL and Let's Encrypt as valid Certificate Authorities, with supporting references and configuration examples. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 21029323 | Triggered | Generic High Entropy Secret | 097990c | scripts/generate-llms-txt-sections.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Looks good. |
Description (required)
There has been an increase in customers with CAA records set preventing certificate issuance, so add explicit notes about CAA records to custom domain documentation.
These changes were written by Cursor, prompts:
Summary by CodeRabbit