Skip to content

build: generate 404.html file during new deploy release #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ToMESSKa wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

build: generate 404.html file during new deploy release #2381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ jobs:
esac
- name: Build docs-app
run: pnpm run build:docs
- name: Copy index.html to 404.html for GitHub Pages
run: cp ./packages/__docs__/__build__/index.html ./packages/__docs__/__build__/404.html
Comment on lines +43 to +44
Copy link
Contributor Author

@ToMESSKa ToMESSKa Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

404.html is just a copy of index.html (which is generated after running pnpm run build:docs).
The clean-exclude: (see below) script removes everything not in the source (./packages/__docs__/__build__/), so 404.html should be put there.

Copy link
Collaborator

@matyasf matyasf Jan 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the preview.yml script keeps the 404.html file because it doesnt call clean-exclude?

Copy link
Contributor Author

@ToMESSKa ToMESSKa Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matyasf I think preview.yml deploys to a completely different location (the gh-pages/pr-preview/....), not to the root of gh-pages where the main 404.html file is, so it never touches the 404.html file.

- name: Deploy to GitHub Pages
uses: JamesIves/github-pages-deploy-action@v4
with:
Expand Down
Loading