Skip to content

build: generate 404.html file during new deploy release #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ToMESSKa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: generate 404.html file during new deploy release #2381

ToMESSKa wants to merge 1 commit into from
+2 −0

Conversation

@ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Jan 23, 2026 •
edited
Loading

INSTUI-4905

ISSUE:

@ToMESSKa ToMESSKa self-assigned this Jan 23, 2026
ToMESSKa
ToMESSKa commented Jan 23, 2026
View reviewed changes
.github/workflows/deploy.yml
Comment on lines +43 to +44
- name: Copy index.html to 404.html for GitHub Pages
run: cp ./packages/__docs__/__build__/index.html ./packages/__docs__/__build__/404.html
Copy link
Contributor Author

@ToMESSKa ToMESSKa Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

404.html is just a copy of index.html (which is generated after running pnpm run build:docs).
The clean-exclude: (see below) script removes everything not in the source (./packages/__docs__/__build__/), so 404.html should be put there.

Copy link
Collaborator

@matyasf matyasf Jan 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the preview.yml script keeps the 404.html file because it doesnt call clean-exclude?

Copy link
Contributor Author

@ToMESSKa ToMESSKa Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matyasf I think preview.yml deploys to a completely different location (the gh-pages/pr-preview/....), not to the root of gh-pages where the main 404.html file is, so it never touches the 404.html file.

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://instructure.design/pr-preview/pr-2381/

Built to branch gh-pages at 2026-01-23 15:28 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

matyasf
matyasf approved these changes Jan 26, 2026
View reviewed changes
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my question, if its not needed for preview.yml, then lets go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matyasf matyasf matyasf approved these changes

@joyenjoyer joyenjoyer joyenjoyer approved these changes

Assignees

@ToMESSKa ToMESSKa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ToMESSKa @matyasf @joyenjoyer