Add hspec-discover to build-tools #64
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without that running the tests via Cabal fails with: could not execute: hspec-discover
sol
suggested changes
May 11, 2023
Contributor
sol
left a comment
sol
left a comment
There was a problem hiding this comment.
hpackdoes not require you to specify the package name if the package name and executable name coincide- You should use the exact same versions of
hspecandhspec-discover.stackensures this,cabalcurrently does not really ensure a consistent set of dependencies (haskell/cabal#5105), but in most cases you will get a consistent set by "being lucky". Adding an additional version constraint forhspec-discoverwill not meaningfully improve anything forcabaland is hence unnecessary clutter.
Comment on lines
+39
to
+40
| build-tools: | ||
| - hspec-discover:hspec-discover >=2 && <3 |
Contributor
There was a problem hiding this comment.
Suggested change
| build-tools: | |
| - hspec-discover:hspec-discover >=2 && <3 | |
| build-tools: hspec-discover |
Comment on lines
+49
to
+50
| build-tools: | ||
| - hspec-discover:hspec-discover >=2 && <3 |
Contributor
There was a problem hiding this comment.
Suggested change
| build-tools: | |
| - hspec-discover:hspec-discover >=2 && <3 | |
| build-tools: hspec-discover |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without that running the tests via Cabal fails with: could not execute: hspec-discover
Moved these changes from #63 to a separate PR as suggest in #63 (comment).