Expose ProcessConfig and friends from the internal module
#63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
These three commits seems logically independent to me, so can you please make them in three separate PRs? Having them in the same PR makes it harder to review. |
This was referenced Feb 26, 2023
mmhat
force-pushed
the
62-expose-processconfig
branch
from
f1a0906 to
264756d
Compare
Contributor
Author
|
@tomjaguarpaw I moved the unrelated changes to #64 and #65. |
Collaborator
|
Thanks. |
Collaborator
|
Not sure why the MacOS tests failed. I guess it's a problem with the tests, not this PR. |
Collaborator
|
Thanks for this, and thanks for being responsive to requests! |
Contributor
Author
|
@tomjaguarpaw Thank you for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I basically moved all the stuff concerned with
ProcessConfig(e.g. setters, smart constructors, ...) to the internal module and re-export it in the public API. This structure appeared simpler to me than having some of the bindings in the internal module and some in the public one: There are a bunch of top-level bindings (likeshell,proc) needed in the instances of the datatypes and unless we go with orphan instances inSystem.Process.Typedthose need to live in the internal module.Fixes #62