Handle GraphViz objects in storage and UI#4855
Closed
eonofrey wants to merge 1 commit intofacebook:mainfrom
Closed
Handle GraphViz objects in storage and UI#4855eonofrey wants to merge 1 commit intofacebook:mainfrom
eonofrey wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4855 +/- ##
==========================================
- Coverage 96.76% 96.75% -0.01%
==========================================
Files 589 589
Lines 61832 61838 +6
==========================================
+ Hits 59829 59834 +5
- Misses 2003 2004 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eonofrey
force-pushed
the
export-D92208435
branch
from
0cbd0b8 to
59753b1
Compare
eonofrey
added a commit
to eonofrey/Ax
that referenced
this pull request
Feb 6, 2026
Summary: In [analysis_card_to_sqa](https://www.internalfb.com/code/fbsource/[f35aae2adf7e14e81702f0f3cd5584af5ce363fd]/fbcode/ax/storage/sqa_store/encoder.py?lines=1161-1171) we support every type of AnalysisCard except GraphViz. This diff has small additions to encoding and decoding for `GraphVizAnalysisCard` so `GenerationStrategyGraph` can be properly stored and rendered in the UI since currently it does not render: {F1985181889} Reviewed By: Cesar-Cardoso Differential Revision: D92208435
eonofrey
force-pushed
the
export-D92208435
branch
from
59753b1 to
215e37e
Compare
eonofrey
added a commit
to eonofrey/Ax
that referenced
this pull request
Feb 6, 2026
Summary: In [analysis_card_to_sqa](https://www.internalfb.com/code/fbsource/[f35aae2adf7e14e81702f0f3cd5584af5ce363fd]/fbcode/ax/storage/sqa_store/encoder.py?lines=1161-1171) we support every type of AnalysisCard except GraphViz. This diff has small additions to encoding and decoding for `GraphVizAnalysisCard` so `GenerationStrategyGraph` can be properly stored and rendered in the UI since currently it does not render: {F1985181889} Reviewed By: Cesar-Cardoso Differential Revision: D92208435
eonofrey
force-pushed
the
export-D92208435
branch
from
215e37e to
7367b76
Compare
Summary: In [analysis_card_to_sqa](https://www.internalfb.com/code/fbsource/[f35aae2adf7e14e81702f0f3cd5584af5ce363fd]/fbcode/ax/storage/sqa_store/encoder.py?lines=1161-1171) we support every type of AnalysisCard except GraphViz. This diff has small additions to encoding and decoding for `GraphVizAnalysisCard` so `GenerationStrategyGraph` can be properly stored and rendered in the UI since currently it does not render: {F1985181889} Reviewed By: Cesar-Cardoso Differential Revision: D92208435
eonofrey
force-pushed
the
export-D92208435
branch
from
7367b76 to
c506f2f
Compare
|
This pull request has been merged in cf654b1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In analysis_card_to_sqa we support every type of AnalysisCard except GraphViz. This diff adds encoding and decoding for
GraphVizAnalysisCardsoGenerationStrategyGraphcan be properly stored and rendered in the UI since currently it does not render:{F1985181889}
Differential Revision: D92208435