Skip to content

Handle GraphViz objects in storage and UI #4855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eonofrey wants to merge 1 commit into from
Closed

Handle GraphViz objects in storage and UI #4855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ax/storage/sqa_store/decoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
from typing import Any, Callable, cast, Union

import pandas as pd
from ax.analysis.graphviz.graphviz_analysis import GraphvizAnalysisCard
from ax.analysis.healthcheck.healthcheck_analysis import HealthcheckAnalysisCard
from ax.analysis.markdown.markdown_analysis import MarkdownAnalysisCard
from ax.analysis.plotly.plotly_analysis import PlotlyAnalysisCard
Expand Down Expand Up @@ -1118,6 +1119,15 @@ def analysis_card_from_sqa(
blob=blob,
timestamp=analysis_card_sqa.timestamp,
)
if blob_annotation == "graphviz":
return GraphvizAnalysisCard(
name=analysis_card_sqa.name,
title=title,
subtitle=subtitle,
df=read_json(StringIO(analysis_card_sqa.dataframe_json)),
blob=blob,
timestamp=analysis_card_sqa.timestamp,
)
return AnalysisCard(
name=analysis_card_sqa.name,
title=title,
Expand Down
3 changes: 3 additions & 0 deletions ax/storage/sqa_store/encoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from logging import Logger
from typing import Any, cast

from ax.analysis.graphviz.graphviz_analysis import GraphvizAnalysisCard
from ax.analysis.healthcheck.healthcheck_analysis import HealthcheckAnalysisCard
from ax.analysis.markdown.markdown_analysis import MarkdownAnalysisCard
from ax.analysis.plotly.plotly_analysis import PlotlyAnalysisCard
Expand Down Expand Up @@ -1167,6 +1168,8 @@ def analysis_card_to_sqa(
blob_annotation = "markdown"
elif isinstance(card, HealthcheckAnalysisCard):
blob_annotation = "healthcheck"
elif isinstance(card, GraphvizAnalysisCard):
blob_annotation = "graphviz"
else:
blob_annotation = "dataframe"

Expand Down