refactor: add @mcp.tool decorators to subtool functions#297
Closed
ezyang wants to merge 2 commits intogh/ezyang/221/basefrom
Closed
refactor: add @mcp.tool decorators to subtool functions#297ezyang wants to merge 2 commits intogh/ezyang/221/basefrom
ezyang wants to merge 2 commits intogh/ezyang/221/basefrom
Conversation
ezyang
added a commit
that referenced
this pull request
May 6, 2025
Delete codemcp.main.codemcp. Instead, annotate every function that this function forwarded SubTool to an mcp.tool itself. In codemcp/tools/init_project.py there is a system_prompt with prompts for each of the subtools; move the doc to the docblock of the function annotated with mcp.tool (so the decorator can pick it up). ```git-revs 47a571b (Base revision) d06834c Add mcp.tool decorator to read_file and update docstring 0668aa0 Add mcp.tool decorator to write_file and update docstring 6ce0a01 Add mcp import to edit_file.py d60a419 Add mcp.tool decorator and update docstring for edit_file 780b01f Add mcp.tool decorator and update docstring for ls 6c123be Add mcp import to init_project.py 540bed6 Add mcp.tool decorator and update docstring for init_project cb411e1 Add mcp import to grep.py 4715dd8 Add mcp.tool decorator and update docstring for grep 01b1e4a Add mcp.tool decorator and update docstring for glob 08f3da7 Add mcp.tool decorator and update docstring for rm acb2563 Add mcp.tool decorator and update docstring for mv e24d68c Add mcp.tool decorator and update docstring for think 57e9aca Add mcp.tool decorator and update docstring for chmod c4512c9 Remove codemcp function and tool imports as they're now directly decorated HEAD Auto-commit lint changes ``` codemcp-id: 297-refactor-add-mcp-tool-decorators-to-subtool-functi ghstack-source-id: 4d82669 Pull-Request-resolved: #297
This was referenced May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Delete codemcp.main.codemcp. Instead, annotate every function that this function forwarded SubTool to an @mcp.tool itself. In codemcp/tools/init_project.py there is a system_prompt with prompts for each of the subtools; move the doc to the docblock of the function annotated with @mcp.tool (so the decorator can pick it up).
codemcp-id: 297-refactor-add-mcp-tool-decorators-to-subtool-functi