fix: Fix tests after refactoring to bypass codemcp.main.codemcp#296
Closed
ezyang wants to merge 2 commits intogh/ezyang/220/basefrom
Closed
fix: Fix tests after refactoring to bypass codemcp.main.codemcp#296ezyang wants to merge 2 commits intogh/ezyang/220/basefrom
ezyang wants to merge 2 commits intogh/ezyang/220/basefrom
Conversation
ezyang
added a commit
that referenced
this pull request
May 6, 2025
Run and fix tests. ```git-revs 2e1cfd3 (Base revision) 20f692c Fix InitProject handling in _dispatch_to_subtool to ensure reuse_head_chat_id parameter is always provided 85a3c4d Update get_chat_id to use _dispatch_to_subtool for consistency with other test methods HEAD Auto-commit lint changes ``` codemcp-id: 296-fix-fix-tests-after-refactoring-to-bypass-codemcp- ghstack-source-id: eab90cc Pull-Request-resolved: #296
This was referenced May 6, 2025
ezyang
added a commit
that referenced
this pull request
May 6, 2025
Run and fix tests. ```git-revs 2e1cfd3 (Base revision) 20f692c Fix InitProject handling in _dispatch_to_subtool to ensure reuse_head_chat_id parameter is always provided 85a3c4d Update get_chat_id to use _dispatch_to_subtool for consistency with other test methods 7cec110 Auto-commit lint changes 81ad53e Update init_project function signature to accept path as an alias for directory 22c8159 Update init_project function body to handle path as an alias for directory de033a2 Fix error messages to use effective_directory instead of directory 162b3e5 Simplify _dispatch_to_subtool for InitProject now that init_project handles both path and directory parameters 1c755e4 Update run_command function signature to accept path as an alias for project_dir 3b6389b Update run_command to handle path parameter as alias for project_dir a6d94cb Update run_command to use effective_project_dir consistently throughout the function HEAD Simplify _dispatch_to_subtool for RunCommand now that run_command handles both path and project_dir parameters ``` codemcp-id: 296-fix-fix-tests-after-refactoring-to-bypass-codemcp- ghstack-source-id: 374212d Pull-Request-resolved: #296
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Run and fix tests.
codemcp-id: 296-fix-fix-tests-after-refactoring-to-bypass-codemcp-