box_tree: Walk the ancestor clips in hit_test_point
#95
+109
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks all the local geometry to perform hit testing, checking the node's local bounds, the local clip, and then the node's ancestors' clips. Rounded rectangle clips are now handled correctly, rather than checking point containment on the underlying `Rect`. Because we need to walk the tree to correctly check the geometry, we do away with the `depth` and `path_to_root` helpers (and build the path in a scratch buffer as we're walking). endoli#93 passes when based on this PR.
tomcur
commented
Dec 23, 2025
| if !clip.rect().contains(local_point) { | ||
| continue; | ||
| } | ||
| walk_tree_and_check_geometry(self, point, id, node, &mut path_buf); |
Contributor
Author
There was a problem hiding this comment.
If Tree::containg_point returns many nodes that share ancestors, we will end up walking those ancestors many times. We could e.g. introduce a scratch buffer (once we've seen a node and know it is contained, we don't need to walk up from that point the next time we hit that same node when walking from a sibling).
We can also do some additional processing on Tree::commit to compress the tree, so hit testing can jump across ancestors that do not clip (those nodes trivially let the hit pass through).
But this first aims for correctness.
waywardmonkeys
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks all the local geometry to perform hit testing, checking the node's local bounds, the local clip, and then the node's ancestors' clips. Rounded rectangle clips are now handled correctly, rather than checking point containment on the underlying
Rect.Because we need to walk the tree to correctly check the geometry, we do away with the
depthandpath_to_roothelpers (and build the path in a scratch buffer as we're walking).#93 passes when based on this PR.