box_tree: Test local bounds checking behavior #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomcur
force-pushed
the
transformed-local-bounds
branch
from
4789780 to
2b4c46d
Compare
tomcur
added a commit
to tomcur/understory
that referenced
this pull request
Dec 23, 2025
This checks all the local geometry to perform hit testing, checking the node's local bounds, the local clip, and then the node's ancestors' clips. Rounded rectangle clips are now handled correctly, rather than checking point containment on the underlying `Rect`. Because we need to walk the tree to correctly check the geometry, we do away with the `depth` and `path_to_root` helpers (and build the path in a scratch buffer as we're walking). endoli#93 passes when based on this PR.
tomcur
added a commit
to tomcur/understory
that referenced
this pull request
Dec 23, 2025
This checks all the local geometry to perform hit testing, checking the node's local bounds, the local clip, and then the node's ancestors' clips. Rounded rectangle clips are now handled correctly, rather than checking point containment on the underlying `Rect`. Because we need to walk the tree to correctly check the geometry, we do away with the `depth` and `path_to_root` helpers (and build the path in a scratch buffer as we're walking). endoli#93 passes when based on this PR.
tomcur
added a commit
that referenced
this pull request
Dec 23, 2025
This checks all the local geometry to perform hit testing, checking the node's local bounds, the local clip, and then the node's ancestors' clips. Rounded rectangle clips are now handled correctly, rather than checking point containment on the underlying `Rect`. Because we need to walk the tree to correctly check the geometry, we do away with the `depth` and `path_to_root` helpers (and build the path in a scratch buffer as we're walking). #93 passes when based on this PR.
This currently fails,as we only check world-space (axis-aligned) bounding boxes, and not local bounds.
tomcur
force-pushed
the
transformed-local-bounds
branch
from
2b4c46d to
3d5cc5d
Compare
waywardmonkeys
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently fails, as we only check world-space (axis-aligned) bounding boxes, and not local bounds.Succeeds on top of #95.