index: Implement Aabb2D<T: Scalar>::from_xywh
#38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomcur
changed the title
Aabb2D<T: Scalar>::from_xywhAabb2D<T: Scalar>::from_xywh
waywardmonkeys
approved these changes
Dec 3, 2025
Contributor
waywardmonkeys
left a comment
waywardmonkeys
left a comment
There was a problem hiding this comment.
Needs a rebase, then you can squash it.
This may be desirable as the generic abstraction; also note there already is an `fn area(Aabb2D<T: Scalar) -> T::Acc` (if we land this, `area` could become a method on `Aabb2D<T: Scalar>`)) The `const`-ness could be gained back with rust-lang/rfcs#3762 at some (hopefully not-too-distant) future Rust version.
tomcur
force-pushed
the
aabb2d-generic
branch
from
98b6e86 to
1e8b4c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be desirable as the generic abstraction; also note there already is an
fn area(Aabb2D<T: Scalar) -> T::Acc(if we land this,areacould become a method onAabb2D<T: Scalar>).The
const-ness could be gained back with rust-lang/rfcs#3762 at some (hopefully not-too-distant) future Rust version.