Skip to content

CI: Improve trigger files on Markdown action #14941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 2 commits into from
Nov 22, 2025
Merged

CI: Improve trigger files on Markdown action #14941

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3cbbaf
CI: Improve trigger files on Markdown action
eksperimental Nov 21, 2025
f0a67e0
Correct setp name in ci-markdown
eksperimental Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/ci-markdown.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,18 @@ on:
push:
branches:
- "main"

paths:
- "**/*.md"
- ".github/workflows/ci-markdown.yml"
- ".markdownlint-cli2.jsonc"

pull_request:
paths:
- "**/*.md"
- ".github/workflows/ci-markdown.yml"
- ".markdownlint-cli2.jsonc"

workflow_dispatch:

permissions:
Expand All @@ -27,10 +34,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Check out the repository
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
with:
fetch-depth: 10
Copy link
Contributor Author

@eksperimental eksperimental Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whatyouhide Do you know why this was being used? Would we still need it?

Copy link
Member

@josevalim josevalim Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To reduce the amount of downloaded data. What is the default checkout uses?

Copy link
Contributor Author

@eksperimental eksperimental Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is 1 (source: https://github.com/actions/checkout?tab=readme-ov-file#checkout-v4)

From what I could read there were issues years ago, and 50 became the standard to overcome that issue, but I think it is long gone.

- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1

- name: Run markdownlint
- name: Run markdownlint-cli2
uses: DavidAnson/markdownlint-cli2-action@30a0e04f1870d58f8d717450cc6134995f993c63 # v21.0.0