Skip to content

Conversation

@eksperimental
Copy link
Contributor

This will trigger the action when the markdownlint-cli2 config or the action yaml file are modified.

This will trigger the action when the markdownlint-cli2 config or
the action yaml file are modified.
- name: Check out the repository
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
with:
fetch-depth: 10
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whatyouhide Do you know why this was being used? Would we still need it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To reduce the amount of downloaded data. What is the default checkout uses?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is 1 (source: https://github.com/actions/checkout?tab=readme-ov-file#checkout-v4)

From what I could read there were issues years ago, and 50 became the standard to overcome that issue, but I think it is long gone.

We actually run markdownlint-cli2, not markdownlint.
@eksperimental
Copy link
Contributor Author

A recent example is this commit 522aebd which didn't trigger the Markdown action

@josevalim josevalim merged commit a2f21c9 into elixir-lang:main Nov 22, 2025
14 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@eksperimental eksperimental deleted the chore/ci-improve-triggers-on-markdown-action branch November 22, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants