Skip to content

Fix replacement logic in replace_server_args (ensure replacement does not use capture indexes) #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yezhiyi9670 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix replacement logic in replace_server_args (ensure replacement does not use capture indexes) #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfba35a
Fix replacement logic in replace_server_args
yezhiyi9670 Dec 5, 2025
cef2682
Fix <Files> section causing crash when handling requests to directories
yezhiyi9670 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions htaccess.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,7 @@ local replace_server_vars = function(str, track_used_headers)
elseif svar == 'time' then -- %{TIME}
replace = os.date('%Y%m%d%H%M%S')
end
result = result:gsub('%%{'..org_svar..'}', replace)..''
result = result:gsub('%%{'..org_svar..'}', replace:gsub('%%', '%%%%')..'')..'' -- make sure no capture indexes are being used as replacement
end
if track_used_headers then
return result, used_headers
Expand Down Expand Up @@ -912,7 +912,7 @@ for statement in htaccess:gmatch('[^\r\n]+') do
-- TODO: Add match as environment variable
-- <FilesMatch "^(?<sitename>[^/]+)"> ==> %{env:MATCH_SITENAME}
end
elseif request_filename == test or request_filename:match(test:gsub('%.', '%.'):gsub('%?', '.'):gsub('*', '.+')) then
elseif request_filename ~= nil and (request_filename == test or request_filename:match(test:gsub('%.', '%.'):gsub('%?', '.'):gsub('*', '.+'))) then
use_block = true
end
elseif tag_name == 'limit' or tag_name == 'limitexcept' then
Expand Down