Fix replacement logic in replace_server_args (ensure replacement does not use capture indexes) #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using unfiltered string as replacement, it is important to escape the
%characters to prevent "invalid capture index" errors. This is properly done in:htaccess-for-nginx/htaccess.lua
Line 1290 in ec2de6a
htaccess-for-nginx/htaccess.lua
Line 1296 in ec2de6a
But not here:
htaccess-for-nginx/htaccess.lua
Line 809 in ec2de6a
Consider this rewrite rule set, which is modified from Wordpress default:
If the last rule is triggered with query string that contains something like
%2C, the script will crash. This commit fixes it by also doingreplace:gsub('%%', '%%%%')..''.The second commit fixed #37. I accidentally committed it to the same branch.