Skip to content

Conversation

@dtebbs
Copy link
Contributor

@dtebbs dtebbs commented Oct 11, 2021

@dtebbs dtebbs changed the title Update libsnark [add-pairing-gadgets] [WIP] Update libsnark [add-pairing-gadgets] Oct 12, 2021
@dtebbs dtebbs changed the title [WIP] Update libsnark [add-pairing-gadgets] [WIP] Update libsnark [add-pairing-gadgets] (depends on #408) Oct 13, 2021
@dtebbs dtebbs changed the base branch from develop to ganache-docker October 13, 2021 10:16
@dtebbs dtebbs marked this pull request as ready for review October 13, 2021 10:17
@dtebbs dtebbs changed the title [WIP] Update libsnark [add-pairing-gadgets] (depends on #408) Update libsnark [add-pairing-gadgets] (depends on #408) Oct 13, 2021
@dtebbs dtebbs force-pushed the update-libsnark branch 3 times, most recently from f7f13c3 to 78bc9e5 Compare October 15, 2021 17:26
@AntoineRondelet AntoineRondelet changed the base branch from ganache-docker to develop October 22, 2021 08:38
@dtebbs dtebbs force-pushed the update-libsnark branch 2 times, most recently from aaf3ad3 to 60b329d Compare November 1, 2021 12:38
@dtebbs dtebbs changed the title Update libsnark [add-pairing-gadgets] (depends on #408) Update libsnark [add-pairing-gadgets] (depends on #413) Nov 1, 2021
@dtebbs
Copy link
Contributor Author

dtebbs commented Nov 1, 2021

#413 contains the fix for the codeql job

@dtebbs dtebbs force-pushed the update-libsnark branch 2 times, most recently from dadc202 to d0418ef Compare November 1, 2021 18:23
@dtebbs dtebbs changed the title Update libsnark [add-pairing-gadgets] (depends on #413) Update libsnark [add-pairing-gadgets] Nov 2, 2021
Copy link
Contributor

@AntoineRondelet AntoineRondelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once rebased on top of origin/develop which now contains the changes from #413

@dtebbs
Copy link
Contributor Author

dtebbs commented Nov 2, 2021

Updated to point to clearmatics/libsnark#407 and rebased.

@AntoineRondelet
Copy link
Contributor

Updated to point to clearmatics/libsnark#407 and rebased.

clearmatics/libsnark#407?

@AntoineRondelet AntoineRondelet requested review from AntoineRondelet and removed request for AntoineRondelet November 2, 2021 13:09
@AntoineRondelet AntoineRondelet merged commit 281a089 into develop Nov 2, 2021
@AntoineRondelet AntoineRondelet deleted the update-libsnark branch November 4, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants