Remove generic gadgets (depends on #83) #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtebbs
force-pushed
the
remove-generic-gadgets
branch
4 times, most recently
from
ac84d21 to
fd38480
Compare
dtebbs
changed the title
dtebbs
force-pushed
the
remove-generic-gadgets
branch
from
fd38480 to
866ae16
Compare
dtebbs
changed the title
dtebbs
force-pushed
the
update-zeth
branch
2 times, most recently
from
b12d268 to
6ca1062
Compare
dtebbs
force-pushed
the
remove-generic-gadgets
branch
from
866ae16 to
64c6ec8
Compare
dtebbs
force-pushed
the
remove-generic-gadgets
branch
from
64c6ec8 to
51708a5
Compare
dtebbs
force-pushed
the
remove-generic-gadgets
branch
from
51708a5 to
dbbea73
Compare
dtebbs
force-pushed
the
remove-generic-gadgets
branch
from
dbbea73 to
fd75604
Compare
dtebbs
force-pushed
the
remove-generic-gadgets
branch
from
fd75604 to
8e4e34b
Compare
AntoineRondelet
approved these changes
Nov 2, 2021
Contributor
AntoineRondelet
left a comment
AntoineRondelet
left a comment
There was a problem hiding this comment.
LGTM thanks @dtebbs
| template<typename wppT, typename nverifierT> | ||
| class verification_key_scalar_hash_gadget | ||
| : public libsnark::gadget<libff::Fr<wppT>> | ||
| class verification_key_hash_gadget : public libsnark::gadget<libff::Fr<wppT>> |
Contributor
There was a problem hiding this comment.
Note to self: verification_key_scalar_hash_gadget is renamed verification_key_hash_gadget, so the default VK hashing behavior is using an algebraic hash like MiMC defined over the relevant prime field. We remove support for the "standard" VK hasher here.
| const libff::bigint<wn> &wmodulus, | ||
| mp_size_t nn, | ||
| const libff::bigint<nn> &nmodulus> | ||
| void fp_from_fp( |
Contributor
There was a problem hiding this comment.
Note to self: Moved to libff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on