release: Deploy DSDL updates to the production site #547
Conversation
Except for the three Cal-ITP brand color variables.
Also includes a few minor color items I missed in the colors PR, primarily standardizing on the modern rgb(r g b / a) syntax, but also adjusting some that didn't look right on closer inspection while working on this PR (most notably, the rainbow list marker colors on the homepage).
And replace `<strong><u>` usage with a proper heading.
✅ Deploy Preview for cal-itp-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cmajel
left a comment
cmajel
left a comment
There was a problem hiding this comment.
So exciting!
I did a review of the typography per our earlier conversation about the challenges with Space Grotesk, since it does not come with italicized fonts. Here's what I'm proposing:
- Use Space Grotesk (current) for all headings and display copy (H1-H6,
.text-titleand.text-display - Use Noto Sans for body copy (body, p, captions,
.small, and.footnote- This has the added benefit of making body copy appear slightly larger, which may help with readability
- This also is the base font for Benefits to encourage continuity/easier maintenance
With this change, I'd also recommend adjusting the default bold in body copy down from 700 to 600.
Double-checking this, @cmajel:
|
|
@Scotchester yes! |
jgravois
left a comment
jgravois
left a comment
There was a problem hiding this comment.
Once we get a thumbs up from @cmajel, time to ship it!
@cmajel blessed this in #554 (comment) 📿
thekaveman
left a comment
thekaveman
left a comment
There was a problem hiding this comment.
It looks great! I was pleasantly surprised at how much more readable the new fonts, weights, spacing, etc. make the site feel.
✨ Nice work y'all!! ✨
|
Just noting that #553 targets this branch, so should probably be merged ahead of this one. |
Closes #532
Once we get a thumbs up from @cmajel, time to ship it!